Нужны советы по оптимизации кода

andyarus · May 7, 2011

Подскажите, как оптимизировать скрипт?

Мне кажется, это же можно сделать намного проще, но как? xpath?

<?php

$a = file_get_contents("http://nagranitse.ru/");

preg_match('#(?>число машин|number of cars).*<td>(?>(\d+)<|(\d+)\s(.*)<).*(?>примерное время ожидания|estimated waiting time).*<td>(.*)</td>.*(?>последнее время обновления|last updated).*<td>(.*)</td>#isU', $a, $one);
preg_match('#(?>число машин|number of cars).*<td>.*<td>(?>(\d+)<|(\d+)\s(.*)<).*(?>примерное время ожидания|estimated waiting time).*<td>.*<td>(.*)</td>.*(?>последнее время обновления|last updated).*<td>.*<td>(.*)</td>#isU', $a, $two);
preg_match('#(?>число машин|number of cars).*<td>.*<td>.*<td>(?>(\d+)<|(\d+)\s(.*)<).*(?>примерное время ожидания|estimated waiting time).*<td>.*<td>.*<td>(.*)</td>.*(?>последнее время обновления|last updated).*<td>.*<td>.*<td>(.*)</td>#isU', $a, $three);

echo "<html><head><style type='text/css'>";
echo "table{width:600px; text-align:center; border-spacing:0;}";
echo "th,td{padding:5px 0;}";
echo "th{background:#D2DCE5;}";
echo "th:first-child{border-radius:10px 0 0 0; -webkit-border-radius:10px 0 0 0; -moz-border-radius:10px 0 0 0;}";
echo "th+th+th{border-radius:0 10px 0 0; -webkit-border-radius:0 10px 0 0; -moz-border-radius:0 10px 0 0;}";
echo "td{border:1px solid #ccc;}";
echo "tr+tr+tr+tr td:first-child{border-radius:0 0 0 10px; -webkit-border-radius:0 0 0 10px; -moz-border-radius:0 0 0 10px;}";
echo "tr+tr+tr+tr td+td+td{border-radius:0 0 10px 0; -webkit-border-radius:0 0 10px 0; -moz-border-radius:0 0 10px 0;}";
echo "</style></head><body>";



if($one[1] !== "" & $two[1] !== "" & $three[1] !== "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>"; 
echo "<tr><td>$one[1]</td><td>$two[1]</td><td>$three[1]</td></tr>";
echo "<tr><td>$one[4]</tr><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
} elseif($one[1] !== "" & $two[1] !== "" & $three[1] == "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>";
echo "<tr><td>$one[1]</td><td>$two[1]</td><td>$three[2] $three[3]</td></tr>";
echo "<tr><td>$one[4]</td><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
} elseif($one[1] !== "" & $two[1] == "" & $three[1] !== "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>";
echo "<tr><td>$one[1]</td><td>$two[2] $two[3]</td><td>$three[1]</td></tr>";
echo "<tr><td>$one[4]</td><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
} elseif($one[1] !== "" & $two[1] == "" & $three[1] == "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>";
echo "<tr><td>$one[1]</td><td>$two[2] $two[3]</td><td>$three[2] $three[3]</td></tr>";
echo "<tr><td>$one[4]</td><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
} elseif($one[1] == "" & $two[1] !== "" & $three[1] !== "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>";
echo "<tr><td>$one[2] $one[3]</td><td>$two[1]</td><td>$three[1]</td></tr>";
echo "<tr><td>$one[4]</td><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
} elseif($one[1] == "" & $two[1] !== "" & $three[1] == "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>";
echo "<tr><td>$one[2] $one[3]</td><td>$two[1]</td><td>$three[2] $three[3]</td></tr>";
echo "<tr></div><td>$one[4]</td><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr></div><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
} elseif($one[1] == "" & $two[1] == "" & $three[1] !== "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>";
echo "<tr><td>$one[2] $one[3]</td><td>$two[2] $two[3]</td><td>$three[1]</td></tr>";
echo "<tr><td>$one[4]</td><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
} elseif($one[1] == "" & $two[1] == "" & $three[1] == "") {
echo "<table>";
echo "<tr><th>Торфяновка</th><th>Брусничное</th><th>Светогорск</th></tr>";
echo "<tr><td>$one[2] $one[3]</td><td>$two[2] $two[3]</td><td>$three[2] $three[3]</td></tr>";
echo "<tr><td>$one[4]</td><td>$two[4]</td><td>$three[4]</td></tr>";
echo "<tr><td>$one[5]</td><td>$two[5]</td><td>$three[5]</td></tr>";
echo "</table>";
}

echo "</body></html>";

?>

Почему код "обрезается"?

Edited May 7, 2011 by andyarus

Veseloff · May 7, 2011

Непонятно что сделать надо. Ставить вопрос следует так: «Задача такая-то. Вот моё решение. Что можно улучшить?»

andyarus · May 7, 2011

Если запустить скрипт, все станет понятно.

Sign In

Нужны советы по оптимизации кода

Question

andyarus

Link to comment

Share on other sites

2 answers to this question

Recommended Posts

Veseloff

Link to comment

Share on other sites

andyarus

Link to comment

Share on other sites

Join the conversation

Обсуждения

Forums

Important Information